Add Meriones unguiculatus to species list #1546
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1546 +/- ##
==========================================
+ Coverage 88.45% 88.54% +0.08%
==========================================
Files 78 78
Lines 10718 10718
==========================================
+ Hits 9481 9490 +9
+ Misses 1237 1228 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dandi/metadata/util.py
Outdated
| @@ -394,6 +394,12 @@ def extract_cellLine(metadata: dict) -> str | None: | |||
| NCBITAXON_URI_TEMPLATE.format("9545"), | |||
| "Macaca nemestrina", | |||
| ), | |||
| ( | |||
| ["Mongolian gerbil", "Mongolian jird"], | |||
There was a problem hiding this comment.
| ["Mongolian gerbil", "Mongolian jird"], | |
| ["mongolian gerbil", "mongolian jird"], |
There was a problem hiding this comment.
ideally IMHO we should make code robust to specification here and just .lower() then when matching. Or do you see an issue with that @jwodder ?
|
Thank you, @yarikoptic @jwodder. Would you be able to make a release this week so that I can notify the user who requested this change? |
|
Sure. with which we could trigger release... if not - I will generate empty PR to trigger it |
|
🚀 PR was released in |
Reference: http://purl.obolibrary.org/obo/NCBITaxon_10047