Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do fail (raise Exception, CLI has non-0 exit) download if any of downloads fail #1536

Merged
merged 2 commits into from
Dec 2, 2024
+34 −5

BF: we need to also wrap callbacks to capture errors in their returns

9b3f2fb
Select commit
Loading
Failed to load commit list.
Merged

Do fail (raise Exception, CLI has non-0 exit) download if any of downloads fail #1536

BF: we need to also wrap callbacks to capture errors in their returns
9b3f2fb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 2, 2024 in 1s

88.53% (+0.06%) compared to 5215b37

View this Pull Request on Codecov

88.53% (+0.06%) compared to 5215b37

Details

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.53%. Comparing base (5215b37) to head (9b3f2fb).

Files with missing lines Patch % Lines
dandi/download.py 82.35% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1536      +/-   ##
==========================================
+ Coverage   88.46%   88.53%   +0.06%     
==========================================
  Files          78       78              
  Lines       10718    10737      +19     
==========================================
+ Hits         9482     9506      +24     
+ Misses       1236     1231       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov