Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor some download code for readability + ensure that we checksum resumed downloads #1535

Merged
merged 5 commits into from
Nov 26, 2024

RF: making type checking happier)

7efa0b2
Select commit
Loading
Failed to load commit list.
Merged

Refactor some download code for readability + ensure that we checksum resumed downloads #1535

RF: making type checking happier)
7efa0b2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 25, 2024 in 0s

88.52% (+0.07%) compared to ff49fd1

View this Pull Request on Codecov

88.52% (+0.07%) compared to ff49fd1

Details

Codecov Report

Attention: Patch coverage is 38.77551% with 30 lines in your changes missing coverage. Please review.

Project coverage is 88.52%. Comparing base (ff49fd1) to head (7efa0b2).

Files with missing lines Patch % Lines
dandi/download.py 23.07% 30 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1535      +/-   ##
==========================================
+ Coverage   88.44%   88.52%   +0.07%     
==========================================
  Files          78       78              
  Lines       10691    10713      +22     
==========================================
+ Hits         9456     9484      +28     
+ Misses       1235     1229       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.