Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify custom ulimit on nofiles to prevent infinite loop by billiard #1533

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Nov 20, 2024

Closes: #1488

See: celery/billiard#417

@asmacdo please verify that it resolves the issue for you too

TODOs

  • after accepted here, we better propose similar one against dandi-archive's compose recipes. In all likeliness situation would be similar there.

@yarikoptic yarikoptic requested a review from jwodder November 20, 2024 21:27
@yarikoptic yarikoptic added the tests Add or improve existing tests label Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.53%. Comparing base (958adbe) to head (ca1f575).
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1533      +/-   ##
==========================================
+ Coverage   88.45%   88.53%   +0.07%     
==========================================
  Files          78       78              
  Lines       10691    10691              
==========================================
+ Hits         9457     9465       +8     
+ Misses       1234     1226       -8     
Flag Coverage Δ
unittests 88.53% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmacdo
Copy link
Member

asmacdo commented Nov 20, 2024

With this change, the tests now pass locally for me thank you!

@yarikoptic
Copy link
Member Author

FTR typing error (can't relate) is (new pydantic?):

typing: commands[0]> mypy dandi
dandi/dandiapi.py:1381: error: No overload variant of "PrivateAttr" matches
argument type "None"  [call-overload]
        _metadata: Optional[Dict[str, Any]] = PrivateAttr(default_factory=...
                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~...
dandi/dandiapi.py:1381: note: Possible overload variants:
dandi/dandiapi.py:1381: note:     def [_T] PrivateAttr(default: _T, *, init: Literal[False] = ...) -> _T
dandi/dandiapi.py:1381: note:     def [_T] PrivateAttr(*, default_factory: Callable[[], _T], init: Literal[False] = ...) -> _T
dandi/dandiapi.py:1381: note:     def PrivateAttr(*, init: Literal[False] = ...) -> Any
Found 1 error in 1 file (checked 81 source files)
typing: exit 1 (16.86 seconds) /home/runner/work/dandi-cli/dandi-cli> mypy dandi pid=2089

@yarikoptic yarikoptic merged commit a7712c3 into master Nov 21, 2024
22 of 25 checks passed
@yarikoptic yarikoptic deleted the bf-1488 branch November 21, 2024 00:54
Copy link

🚀 PR was released in 0.65.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_publish_and_manipulate and test_get_dandiset_published fail locally
3 participants