Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix host used in minio URLs #1487

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Fix host used in minio URLs #1487

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b73532c
Fix host used in minio URLs
jwodder Aug 14, 2024
85f6dd8
Add explanatory comment
jwodder Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dandi/tests/data/dandiarchive-docker/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ services:
DJANGO_MINIO_STORAGE_ENDPOINT: minio:9000
DJANGO_MINIO_STORAGE_SECRET_KEY: minioSecretKey
DJANGO_STORAGE_BUCKET_NAME: django-storage
DJANGO_MINIO_STORAGE_MEDIA_URL: http://localhost:9000/django-storage
DJANGO_MINIO_STORAGE_MEDIA_URL: http://127.0.0.1:9000/django-storage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is odd that it would need it for MINIO but nothing else... but ok, if that resolves it for you I do not mind, but please add a brief comment above on why it is needed. ATM not even commit message provides an explanation -- would be hard to figure out why it was needed and thus might get reverted etc.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment added: 85f6dd8

DJANGO_DANDI_SCHEMA_VERSION: ~
DJANGO_DANDI_WEB_APP_URL: http://localhost:8085
DJANGO_DANDI_API_URL: http://localhost:8000
Expand Down
Loading