-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dump audit table to file specified by DANDI_TESTS_AUDIT_CSV
envvar
#1486
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1486 +/- ##
==========================================
+ Coverage 88.54% 88.62% +0.07%
==========================================
Files 77 77
Lines 10565 10568 +3
==========================================
+ Hits 9355 9366 +11
+ Misses 1210 1202 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, thank you!
That added code ATM not covered on CI. So we do not miss when code starts to rot (e.g. changes to dandi-archive etc), please add setting this env var to some tmp file in a single CI run, and verifying that file is created and has some representative number of records/lines.
note: I am trying to run tests locally with DANDI_TESTS_AUDIT_CSV=/tmp/audit.csv python -m pytest -v dandi/tests/test_dandiapi.py
but they lead to 100% CPU utilization by celery although nothing alarming in that container's logs, very slow progress through tests, and some tests even failing... odd, likely unrelated, but may be worth checking run times of CI before / after this monday when I believe audit was merged...
if auditfile := os.environ.get("DANDI_TESTS_AUDIT_CSV", ""): | ||
with open(auditfile, "wb") as fp: | ||
run( | ||
[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codecov still reports this block not covered by tests -- any idea why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's just due to the annotations on GitHub not being updated. If I go to the Codecov site, the lines are marked covered.
3.10 failed with unrelated (just making note)
|
🚀 PR was released in |
Closes #1484.