Update for zarr_checksum 0.2.12
#1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We can't update to `zarr_checksum` 0.3.0 yet, as that requires Pydantic v2. - As `zarr_checksum` gained type annotations in dandi/zarr_checksum#21, we can remove its override from the mypy config. - Since dandi/zarr_checksum#17 was merged, it's now safe to import `zarr_checksum` at the top level of a module. - Fixed a typing error caused by importing `ZarrChecksumTree` from the top level of `zarr_checksum` despite it not being listed in `zarr_checksum.__all__`, which triggered a typing failure due to our mypy configuration containing `implicit_reexport = False`. (This error could only be detected after `zarr_checksum` started shipping a `py.typed` file.)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1365 +/- ##
==========================================
+ Coverage 88.69% 88.77% +0.08%
==========================================
Files 77 77
Lines 10434 10434
==========================================
+ Hits 9254 9263 +9
+ Misses 1180 1171 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thank you @jwodder ! as we are many commits after release, let's release while at it. |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't update to
zarr_checksum0.3.0 yet, as that requires Pydantic v2.As
zarr_checksumgained type annotations in Add & declare type-checking zarr_checksum#21, we can remove its override from the mypy config.Since Avoid importing zarr library unless necessary zarr_checksum#17 was merged, it's now safe to import
zarr_checksumat the top level of a module.Fixed a typing error caused by importing
ZarrChecksumTreefrom the top level ofzarr_checksumdespite it not being listed inzarr_checksum.__all__, which triggered a typing failure due to our mypy configuration containingimplicit_reexport = False. (This error could only be detected afterzarr_checksumstarted shipping apy.typedfile.)