Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dataclass instead of auto_repr #1349

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Use dataclass instead of auto_repr #1349

merged 1 commit into from
Nov 9, 2023

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Nov 8, 2023

No description provided.

@jwodder jwodder added internal Changes only affect the internal API code quality Nonfunctional improvements to the codebase labels Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b6717fb) 89.05% compared to head (a4210bf) 89.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1349      +/-   ##
==========================================
+ Coverage   89.05%   89.14%   +0.09%     
==========================================
  Files          75       75              
  Lines       10284    10268      -16     
==========================================
- Hits         9158     9153       -5     
+ Misses       1126     1115      -11     
Flag Coverage Δ
unittests 89.14% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
dandi/download.py 88.40% <100.00%> (-0.06%) ⬇️
dandi/support/digests.py 100.00% <100.00%> (ø)
dandi/utils.py 86.38% <100.00%> (+2.47%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dandi/utils.py Dismissed Show dismissed Hide dismissed
dandi/utils.py Dismissed Show dismissed Hide dismissed
@yarikoptic yarikoptic merged commit 3c18712 into master Nov 9, 2023
25 checks passed
@yarikoptic yarikoptic deleted the no-auto-repr branch November 9, 2023 16:40
Copy link

🚀 PR was released in 0.58.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Nonfunctional improvements to the codebase internal Changes only affect the internal API released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants