Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace _pytest imports with modern pytest imports #1347

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Nov 8, 2023

No description provided.

@jwodder jwodder added internal Changes only affect the internal API code quality Nonfunctional improvements to the codebase labels Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9335182) 89.04% compared to head (bcd1d93) 89.03%.
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1347      +/-   ##
==========================================
- Coverage   89.04%   89.03%   -0.02%     
==========================================
  Files          76       76              
  Lines       10243    10240       -3     
==========================================
- Hits         9121     9117       -4     
- Misses       1122     1123       +1     
Flag Coverage Δ
unittests 89.03% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
dandi/conftest.py 100.00% <100.00%> (ø)
dandi/tests/fixtures.py 97.55% <ø> (-0.01%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's merge when CI finishes up

@jwodder
Copy link
Member Author

jwodder commented Nov 8, 2023

@yarikoptic CI is currently quiet.

@yarikoptic yarikoptic merged commit cb86c9c into master Nov 9, 2023
23 of 24 checks passed
@yarikoptic yarikoptic deleted the pytest-up branch November 9, 2023 16:43
Copy link

🚀 PR was released in 0.58.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Nonfunctional improvements to the codebase internal Changes only affect the internal API released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants