Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace appdirs with platformdirs #1345

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Replace appdirs with platformdirs #1345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dandi/cli/command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
import sys
from types import SimpleNamespace

import appdirs
import click
from click_didyoumean import DYMGroup
import platformdirs

from .base import lgr, map_to_click_exceptions
from .. import __version__, set_logger_level
Expand Down Expand Up @@ -97,7 +97,7 @@
h.addFilter(lambda r: not getattr(r, "file_only", False))
set_logger_level(h, log_level)

logdir = appdirs.user_log_dir("dandi-cli", "dandi")
logdir = platformdirs.user_log_dir("dandi-cli", "dandi")

Check warning on line 100 in dandi/cli/command.py

View check run for this annotation

Codecov / codecov/patch

dandi/cli/command.py#L100 

Added line #L100 was not covered by tests
logfile = os.path.join(
logdir, "{:%Y%m%d%H%M%SZ}-{}.log".format(datetime.utcnow(), os.getpid())
)
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ project_urls =
[options]
python_requires = >=3.8
install_requires =
appdirs
bidsschematools ~= 0.7.0
click
click-didyoumean
Expand All @@ -44,6 +43,7 @@ install_requires =
keyring != 23.9.0
keyrings.alt
packaging
platformdirs
pycryptodomex # for EncryptedKeyring backend in keyrings.alt
pydantic >= 1.9.0
pynwb >= 1.0.3,!=1.1.0,!=2.3.0
Expand Down
1 change: 0 additions & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ commands =
[testenv:typing]
deps =
mypy
types-appdirs
types-python-dateutil
types-requests
commands =
Expand Down