Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize type annotations and improve mypy config #1343

Merged
merged 4 commits into from
Nov 8, 2023
Merged

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Nov 8, 2023

No description provided.

@jwodder jwodder added internal Changes only affect the internal API code quality Nonfunctional improvements to the codebase labels Nov 8, 2023
@jwodder jwodder marked this pull request as draft November 8, 2023 13:54
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (9335182) 89.04% compared to head (f23cfff) 89.05%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1343   +/-   ##
=======================================
  Coverage   89.04%   89.05%           
=======================================
  Files          76       75    -1     
  Lines       10243    10284   +41     
=======================================
+ Hits         9121     9158   +37     
- Misses       1122     1126    +4     
Flag Coverage Δ
unittests 89.05% <97.35%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
dandi/cli/__init__.py 80.00% <100.00%> (ø)
dandi/cli/cmd_move.py 100.00% <ø> (ø)
dandi/cli/cmd_validate.py 78.78% <100.00%> (ø)
dandi/cli/tests/test_cmd_ls.py 100.00% <100.00%> (ø)
dandi/cli/tests/test_command.py 100.00% <100.00%> (ø)
dandi/cli/tests/test_download.py 88.70% <100.00%> (ø)
dandi/cli/tests/test_instances.py 100.00% <100.00%> (ø)
dandi/cli/tests/test_move.py 100.00% <100.00%> (ø)
dandi/cli/tests/test_service_scripts.py 98.24% <100.00%> (ø)
dandi/conftest.py 100.00% <100.00%> (ø)
... and 36 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwodder jwodder marked this pull request as ready for review November 8, 2023 14:54
@yarikoptic yarikoptic merged commit b6717fb into master Nov 8, 2023
25 checks passed
@yarikoptic yarikoptic deleted the better-types branch November 8, 2023 16:13
Copy link

🚀 PR was released in 0.58.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Nonfunctional improvements to the codebase internal Changes only affect the internal API released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants