Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing: Account for the fact that requests.HTTPError .response migth be None now #1335

Closed
wants to merge 1 commit into from

typing: Account for the fact that requests.HTTPError .response migth …

f61f6b8
Select commit
Loading
Failed to load commit list.
Closed

typing: Account for the fact that requests.HTTPError .response migth be None now #1335

typing: Account for the fact that requests.HTTPError .response migth …
f61f6b8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 16, 2023 in 0s

62.36% (-26.42%) compared to a0199fc

View this Pull Request on Codecov

62.36% (-26.42%) compared to a0199fc

Details

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (a0199fc) 88.78% compared to head (f61f6b8) 62.36%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1336       +/-   ##
===========================================
- Coverage   88.78%   62.36%   -26.42%     
===========================================
  Files          76       76               
  Lines       10216    10216               
===========================================
- Hits         9070     6371     -2699     
- Misses       1146     3845     +2699     
Files Coverage Δ
dandi/dandiapi.py 52.45% <ø> (-34.16%) ⬇️
dandi/download.py 71.40% <0.00%> (-16.56%) ⬇️
dandi/files/bases.py 49.29% <0.00%> (-29.23%) ⬇️
dandi/files/zarr.py 41.56% <0.00%> (-47.50%) ⬇️
dandi/dandiarchive.py 62.02% <0.00%> (-23.00%) ⬇️

... and 26 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.