Move attempt >= attempts_allowed check

dandi · Dec 20, 2024 · bb05a23 · bb05a23
1 parent f7e6ea4
commit bb05a23
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/dandi/download.py b/dandi/download.py
@@ -1103,8 +1103,11 @@ def _check_if_more_attempts_allowed(
                 downloaded_in_attempt,
             )
             attempts_allowed += 1
+    if attempt >= attempts_allowed:
+        lgr.debug("%s - download failed after %d attempts: %s", path, attempt, exc)
+        return None
     # TODO: actually we should probably retry only on selected codes,
-    if exc.response is not None:
+    elif exc.response is not None:
         if exc.response.status_code not in (
             400,  # Bad Request, but happened with gider:
             # https://github.com/dandi/dandi-cli/issues/87
@@ -1147,9 +1150,6 @@ def _check_if_more_attempts_allowed(
                 attempt,
                 exc,
             )
-    elif attempt >= attempts_allowed:
-        lgr.debug("%s - download failed after %d attempts: %s", path, attempt, exc)
-        return None
     # if is_access_denied(exc) or attempt >= 2:
     #     raise
     # sleep a little and retry