Make LGTM ignore false positives

dandi/__init__.py

@@ -13,7 +13,7 @@
 from .due import Doi, due
 
 due.cite(
-    Doi("10.5281/zenodo.3692138"),
+    Doi("10.5281/zenodo.3692138"),  # lgtm [py/procedure-return-value-used]
     cite_module=True,  # highly specialized -- if imported, means used.
     description="Client to interact with DANDI Archive",
     path="dandi-cli",

dandi/conftest.py

@@ -1,4 +1,4 @@
-from .tests.fixtures import *  # noqa: F401, F403
+from .tests.fixtures import *  # noqa: F401, F403  # lgtm [py/polluting-import]
 
 
 def pytest_addoption(parser):

dandi/due.py

@@ -55,7 +55,7 @@ def _donothing_func(*args, **kwargs):
 
 
 try:
-    from duecredit import due, BibTeX, Doi, Url, Text
+    from duecredit import due, Doi  # lgtm [py/unused-import]
 
     if "due" in locals() and not hasattr(due, "cite"):
         raise RuntimeError("Imported due lacks .cite. DueCredit is now disabled")
@@ -68,7 +68,7 @@ def _donothing_func(*args, **kwargs):
         )
     # Initiate due stub
     due = InactiveDueCreditCollector()
-    BibTeX = Doi = Url = Text = _donothing_func
+    Doi = _donothing_func
 
 # Emacs mode definitions
 # Local Variables:

dandi/support/generatorify.py

@@ -121,7 +121,7 @@ def __call__(self, callback):
             while True:
                 try:
                     v_from_c = callback(from_g)
-                except BaseException as e_from_c:
+                except BaseException as e_from_c:  # lgtm [py/catch-base-exception]
                     try:
                         from_g = g.throw(e_from_c)
                     except StopIteration as si:

dandi/support/iterators.py

@@ -90,7 +90,7 @@ def worker():
                     self.total = total = (
                         self.agg(value, total) if total is not None else self.agg(value)
                     )
-            except BaseException as e:
+            except BaseException as e:  # lgtm [py/catch-base-exception]
                 self._exc = e
             finally:
                 self.finished = True
@@ -114,4 +114,4 @@ def worker():
                 continue
         t.join()
         if self._exc is not None:
-            raise self._exc
+            raise self._exc  # lgtm [py/illegal-raise]