-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add audit backend #1886
Add audit backend #1886
Commits on Mar 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5b92f2c - Browse repository at this point
Copy the full SHA 5b92f2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ad7856 - Browse repository at this point
Copy the full SHA 5ad7856View commit details -
Configuration menu - View commit details
-
Copy full SHA for 31472ee - Browse repository at this point
Copy the full SHA 31472eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for eccedd9 - Browse repository at this point
Copy the full SHA eccedd9View commit details -
Configuration menu - View commit details
-
Copy full SHA for c50290b - Browse repository at this point
Copy the full SHA c50290bView commit details -
Configuration menu - View commit details
-
Copy full SHA for fdb49a5 - Browse repository at this point
Copy the full SHA fdb49a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ad599d - Browse repository at this point
Copy the full SHA 1ad599dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f0fc96 - Browse repository at this point
Copy the full SHA 7f0fc96View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c9c6b3 - Browse repository at this point
Copy the full SHA 2c9c6b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 01f1b85 - Browse repository at this point
Copy the full SHA 01f1b85View commit details -
Configuration menu - View commit details
-
Copy full SHA for 52ff47e - Browse repository at this point
Copy the full SHA 52ff47eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 08b26c6 - Browse repository at this point
Copy the full SHA 08b26c6View commit details
Commits on Jul 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5134ef7 - Browse repository at this point
Copy the full SHA 5134ef7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f21061 - Browse repository at this point
Copy the full SHA 7f21061View commit details -
Configuration menu - View commit details
-
Copy full SHA for 38d1a29 - Browse repository at this point
Copy the full SHA 38d1a29View commit details -
Configuration menu - View commit details
-
Copy full SHA for 50d80e6 - Browse repository at this point
Copy the full SHA 50d80e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 90c8bc8 - Browse repository at this point
Copy the full SHA 90c8bc8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e204c5 - Browse repository at this point
Copy the full SHA 6e204c5View commit details -
Remove Dandiset add_owner() and remove_owner() methods
This came up during development of the audit functionality. It turns out that add_owner() was only called during Dandiset creation to add the creating user as the only owner, and remove_owner() is never called. Instead, in the method that changes the owner set, assign_perm() is used in all cases to add and remove owners as needed. Since no other point of use exists for adding/removing users, it makes sense to remove these methods.
Configuration menu - View commit details
-
Copy full SHA for f772fc5 - Browse repository at this point
Copy the full SHA f772fc5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0337f41 - Browse repository at this point
Copy the full SHA 0337f41View commit details -
Report live metadata to audit records
Retrieving the metadata fresh from the model enables two things: 1. To report all "computed" metadata values that are derived from the supplied metadata. 2. To enable a changed `name` field on the Dandiset model to be properly reported via the metadata.
Configuration menu - View commit details
-
Copy full SHA for 751d8b5 - Browse repository at this point
Copy the full SHA 751d8b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c125bd - Browse repository at this point
Copy the full SHA 6c125bdView commit details -
Suppress ruff warnings for complexity and number of arguments
The `add_asset_to_version()` service function represents essential complexity in the actual domain. We may be able to simplify it by refactoring the function into smaller parts, but we will look into that independently.
Configuration menu - View commit details
-
Copy full SHA for fcd288c - Browse repository at this point
Copy the full SHA fcd288cView commit details -
Configuration menu - View commit details
-
Copy full SHA for cbff890 - Browse repository at this point
Copy the full SHA cbff890View commit details
Commits on Jul 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a6489b6 - Browse repository at this point
Copy the full SHA a6489b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for e120f86 - Browse repository at this point
Copy the full SHA e120f86View commit details -
Eliminate the need for manually calling .save()
Now that the audit records are generated within service functions, it makes less sense to leak the detail of an AuditRecord instance coming from the function that must then be saved to the database--the service itself can just take care of this.
Configuration menu - View commit details
-
Copy full SHA for 6e4c2bb - Browse repository at this point
Copy the full SHA 6e4c2bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c2ce5d - Browse repository at this point
Copy the full SHA 2c2ce5dView commit details
Commits on Jul 26, 2024
-
Remove references to deleted model fields
The `blob`/`embargoed_blob` distinction was removed in the embargo redesign.
Configuration menu - View commit details
-
Copy full SHA for c5380de - Browse repository at this point
Copy the full SHA c5380deView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9501e03 - Browse repository at this point
Copy the full SHA 9501e03View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9fa7b41 - Browse repository at this point
Copy the full SHA 9fa7b41View commit details
Commits on Jul 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 222a15f - Browse repository at this point
Copy the full SHA 222a15fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3483e50 - Browse repository at this point
Copy the full SHA 3483e50View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a33a6b - Browse repository at this point
Copy the full SHA 4a33a6bView commit details
Commits on Aug 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b5ad8b2 - Browse repository at this point
Copy the full SHA b5ad8b2View commit details -
Use nested transaction to handle integrity error
The notes in the "avoid catching exceptions" callout here (https://docs.djangoproject.com/en/5.0/topics/db/transactions/#controlling-transactions-explicitly) say to do something like this to isolate error handling without stepping on the operation of the transactions themselves.
Configuration menu - View commit details
-
Copy full SHA for 7e04c83 - Browse repository at this point
Copy the full SHA 7e04c83View commit details -
Co-authored-by: Jacob Nesbitt <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1a0faf7 - Browse repository at this point
Copy the full SHA 1a0faf7View commit details -
Configuration menu - View commit details
-
Copy full SHA for cee70a5 - Browse repository at this point
Copy the full SHA cee70a5View commit details
Commits on Aug 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9a2a2b2 - Browse repository at this point
Copy the full SHA 9a2a2b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8af0957 - Browse repository at this point
Copy the full SHA 8af0957View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a225f4 - Browse repository at this point
Copy the full SHA 0a225f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 84b37bc - Browse repository at this point
Copy the full SHA 84b37bcView commit details