Misc code cleanup

src/api/update_status.rs

@@ -23,16 +23,6 @@ impl Default for UpdateStatus {
     }
 }
 
-impl UpdateStatus {
-    pub fn time(&self) -> u64 {
-        match self {
-            Self::UpToDate(t) | Self::HasNewFile(t) | Self::OutOfDate(t) | Self::IgnoredUntil(t) | Self::Invalid(t) => {
-                *t
-            }
-        }
-    }
-}
-
 // Hack to retain backward compatibility with previously serialized data and provide a better API than two atomics
 #[derive(Clone, Debug)]
 pub struct UpdateStatusWrapper {
@@ -71,7 +61,7 @@ impl UpdateStatusWrapper {
     }
 
     pub fn sync_with(&self, other: &Self) {
-        if self.time.load(Ordering::Relaxed) < other.time.load(Ordering::Relaxed) {
+        if self.time() < other.time() {
             self.set(other.to_enum());
         } else {
             other.set(self.to_enum());

src/cache/mod.rs

@@ -178,21 +178,15 @@ impl Cache {
         let mut file = File::create(path).await?;
         file.write_all(format!("{}", time).as_bytes()).await
     }
-
-    // Loads timestamp from $XDG_CACHE_DIR/dmodman/$profile/last_updated
-    pub fn load_last_updated(&self, config: &Config) -> Arc<AtomicU64> {
-        let val = try_read_last_updated(config);
-        self.last_update_check.store(val, Ordering::Relaxed);
-        Arc::new(AtomicU64::new(val))
-    }
 }
 
+// Loads timestamp from $XDG_CACHE_DIR/dmodman/$profile/last_updated
 fn try_read_last_updated(config: &Config) -> u64 {
     let mut path = config.cache_for_profile();
     path.push("last_updated");
     match std::fs::read_to_string(path) {
         Ok(contents) => contents.parse::<u64>().unwrap_or_default(),
-        Err(_) => 0
+        Err(_) => 0,
     }
 }
 

src/cache/modfile_metadata.rs

@@ -80,6 +80,7 @@ impl ModFileMetadata {
         self.file_details.read().await.as_ref().map(|fd| fd.name.clone())
     }
 
+    #[allow(dead_code)]
     pub async fn mod_info(&self) -> Option<Arc<ModInfo>> {
         self.mod_info.read().await.clone()
     }