Fixing naming inconsistency

dan-rubinstein · Sep 24, 2024 · a1d6785 · a1d6785
1 parent d9a58d0
commit a1d6785
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/...ugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/ServiceUtils.java b/...ugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/ServiceUtils.java
@@ -202,7 +202,7 @@ public static ElasticsearchStatusException unknownSettingsError(Map<String, Obje
         );
     }
 
-    public static ElasticsearchStatusException invalidModelTypeForUpdateEmbeddingsModelDetails(Class<? extends Model> invalidModelType) {
+    public static ElasticsearchStatusException invalidModelTypeForUpdateModelWithEmbeddingDetails(Class<? extends Model> invalidModelType) {
         throw new ElasticsearchStatusException(
             Strings.format("Can't update embedding details for model with unexpected type %s", invalidModelType),
             RestStatus.BAD_REQUEST

diff --git a/...java/org/elasticsearch/xpack/inference/services/googleaistudio/GoogleAiStudioService.java b/...java/org/elasticsearch/xpack/inference/services/googleaistudio/GoogleAiStudioService.java
@@ -209,7 +209,7 @@ public Model updateModelWithEmbeddingDetails(Model model, int embeddingSize) {
 
             return new GoogleAiStudioEmbeddingsModel(embeddingsModel, updatedServiceSettings);
         } else {
-            throw ServiceUtils.invalidModelTypeForUpdateEmbeddingsModelDetails(model.getClass());
+            throw ServiceUtils.invalidModelTypeForUpdateModelWithEmbeddingDetails(model.getClass());
         }
     }
 

diff --git a/.../main/java/org/elasticsearch/xpack/inference/services/huggingface/HuggingFaceService.java b/.../main/java/org/elasticsearch/xpack/inference/services/huggingface/HuggingFaceService.java
@@ -89,7 +89,7 @@ public Model updateModelWithEmbeddingDetails(Model model, int embeddingSize) {
 
             return new HuggingFaceEmbeddingsModel(embeddingsModel, updatedServiceSettings);
         } else {
-            throw ServiceUtils.invalidModelTypeForUpdateEmbeddingsModelDetails(model.getClass());
+            throw ServiceUtils.invalidModelTypeForUpdateModelWithEmbeddingDetails(model.getClass());
         }
     }
 

diff --git a/...ence/src/main/java/org/elasticsearch/xpack/inference/services/mistral/MistralService.java b/...ence/src/main/java/org/elasticsearch/xpack/inference/services/mistral/MistralService.java
@@ -236,7 +236,7 @@ public Model updateModelWithEmbeddingDetails(Model model, int embeddingSize) {
             );
             return new MistralEmbeddingsModel(embeddingsModel, updatedServiceSettings);
         } else {
-            throw ServiceUtils.invalidModelTypeForUpdateEmbeddingsModelDetails(model.getClass());
+            throw ServiceUtils.invalidModelTypeForUpdateModelWithEmbeddingDetails(model.getClass());
         }
     }
 }
diff --git a/...erence/src/main/java/org/elasticsearch/xpack/inference/services/openai/OpenAiService.java b/...erence/src/main/java/org/elasticsearch/xpack/inference/services/openai/OpenAiService.java
@@ -269,7 +269,7 @@ public Model updateModelWithEmbeddingDetails(Model model, int embeddingSize) {
 
             return new OpenAiEmbeddingsModel(embeddingsModel, updatedServiceSettings);
         } else {
-            throw ServiceUtils.invalidModelTypeForUpdateEmbeddingsModelDetails(model.getClass());
+            throw ServiceUtils.invalidModelTypeForUpdateModelWithEmbeddingDetails(model.getClass());
         }
     }