Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring & improvements #1

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Conversation

Feynallein
Copy link

Hello,
I worked a lot on your widget in order to improve it:

  • Reindenting code
  • Making the example clearer
  • Improved the angle to hour conversion
  • Improved the number's placements on the clock
  • Made the whole widget more adaptable at different sizes
  • Adding comments to widget's parameters
  • Changed project's tree file so it's easier to locate stuff
  • Renaming some functions/variables to make them clearer
  • Changed the callback's return value to a new type SimpleTime (which holds two variables: hours & minutes) + a bunch of toString methods (toString, toDuration, toAMPMString) and few constructors.

Feel free to ask me any question if needed!
I hope that you will accept this pull request.

Have a good day.

@Feynallein
Copy link
Author

Edit:

  • Added initial values option
  • Removing Flutter 3.0 warning (with WidgetsBinding)
  • Fixed a bug with clock's display

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant