Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: code scanning alert no. 174: Log Injection #352

Merged
merged 12 commits into from
Sep 30, 2024
Merged

fix: code scanning alert no. 174: Log Injection #352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
44d23de
Fix code scanning alert no. 173: Log Injection
yacosta738 Sep 30, 2024
26b190b
Fix code scanning alert no. 174: Log Injection
yacosta738 Sep 30, 2024
ce6d89d
Fix code scanning alert no. 167: Log Injection
yacosta738 Sep 30, 2024
1900ecb
Merge remote-tracking branch 'origin/autofix/alert-167-5a1e781153' in…
yacosta738 Sep 30, 2024
284aeb0
Merge branch 'main' into autofix/alert-174-ba9eeb38e8
yacosta738 Sep 30, 2024
9a0df3f
Merge branch 'main' into autofix/alert-173-d2fd95c38f
yacosta738 Sep 30, 2024
4537476
fix: code scanning alert no. 317: Log Injection
yacosta738 Sep 30, 2024
5d42421
Merge branch 'main' into autofix/alert-174-ba9eeb38e8
yacosta738 Sep 30, 2024
67daac0
Merge branch 'main' into autofix/alert-173-d2fd95c38f
yacosta738 Sep 30, 2024
b4a1013
fix: code scanning alert no. 174: Log Injection #352
yacosta738 Sep 30, 2024
d6423cb
Merge remote-tracking branch 'origin/autofix/alert-173-d2fd95c38f' in…
yacosta738 Sep 30, 2024
f527add
fix: code scanning alert no. 173: Log Injection #351
yacosta738 Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion apps/backend/src/main/kotlin/com/lyra/app/users/application/UserRegistrator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import com.lyra.common.domain.Service
import com.lyra.common.domain.bus.event.EventBroadcaster
import com.lyra.common.domain.bus.event.EventPublisher
import com.lyra.common.domain.error.BusinessRuleValidationException
import org.apache.commons.text.StringEscapeUtils
import org.slf4j.LoggerFactory

@Service
Expand All @@ -24,7 +25,10 @@ class UserRegistrator(
}

suspend fun registerNewUser(registerUserCommand: RegisterUserCommand): ApiDataResponse<UserResponse> {
log.info("Registering new user with email: {}", registerUserCommand.email)
log.info(
"Registering new user with email: {}",
StringEscapeUtils.escapeJava(registerUserCommand.email),
)
return try {
val user = registerUserCommand.toUser()
val createdUser = userCreator.create(user)
Expand Down
3 changes: 2 additions & 1 deletion .../backend/src/main/kotlin/com/lyra/app/users/infrastructure/http/UserRegisterController.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import com.lyra.app.users.infrastructure.http.request.RegisterUserRequest
import io.swagger.v3.oas.annotations.Operation
import io.swagger.v3.oas.annotations.responses.ApiResponse
import io.swagger.v3.oas.annotations.responses.ApiResponses
import org.apache.commons.text.StringEscapeUtils
import org.slf4j.LoggerFactory
import org.springframework.http.HttpStatus
import org.springframework.http.ResponseEntity
Expand All @@ -30,7 +31,7 @@ class UserRegisterController(private val userRegistrator: UserRegistrator) {
@PostMapping("/register")
suspend fun registerUser(@Validated @RequestBody registerUserRequest: RegisterUserRequest):
ResponseEntity<ApiDataResponse<UserResponse>> {
log.info("Registering new user with email: {}", registerUserRequest.email)
log.info("Registering new user with email: {}", StringEscapeUtils.escapeJava(registerUserRequest.email))
return try {
val response = userRegistrator.registerNewUser(registerUserRequest.toRegisterUserCommand())
mapRegistrationResult(response)
Expand Down
Loading