fix: code scanning alert no. 173: Log Injection #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Yuniel Acosta Pérez <[email protected]>
Job Summary for GradleCommit Stage 🤖 :: code-coverage
|
yacosta738
changed the title
yacosta738
added a commit
that referenced
this pull request
Sep 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
=======================================
Coverage 91.52% 91.52%
=======================================
Files 360 360
Lines 4344 4344
Branches 374 374
=======================================
Hits 3976 3976
Misses 237 237
Partials 131 131 ☔ View full report in Codecov by Sentry. |
yacosta738
pushed a commit
that referenced
this pull request
Sep 30, 2024
## [1.14.1](v1.14.0...v1.14.1) (2024-09-30) ### Bug Fixes * code scanning alert no. 173: Log Injection [#351](#351) ([f527add](f527add)) * code scanning alert no. 174: Log Injection [#352](#352) ([b4a1013](b4a1013)) * code scanning alert no. 175: Log Injection ([#347](#347)) ([05a2c01](05a2c01)) * code scanning alert no. 317: Log Injection ([4537476](4537476))
yacosta738
pushed a commit
that referenced
this pull request
Sep 30, 2024
## [1.14.1](v1.14.0...v1.14.1) (2024-09-30) ### Bug Fixes * code scanning alert no. 173: Log Injection [#351](#351) ([f527add](f527add)) * code scanning alert no. 174: Log Injection [#352](#352) ([b4a1013](b4a1013)) * code scanning alert no. 175: Log Injection ([#347](#347)) ([05a2c01](05a2c01)) * code scanning alert no. 317: Log Injection ([4537476](4537476))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dallay/lyra/security/code-scanning/173
To fix the log injection issue, we need to sanitize the user input before logging it. Specifically, we should remove any newline characters from the email address to prevent log injection attacks. This can be achieved by replacing newline characters with an empty string.
registerNewUsermethod inUserRegistrator.ktto sanitize theregisterUserCommand.emailbefore logging it.Suggested fixes powered by Copilot Autofix. Review carefully before merging.