Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ConditionallySelectable supertrait #137

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Change ConditionallySelectable supertrait #137

wants to merge 1 commit into from

Commits on Aug 3, 2024

  1. Change ConditionallySelectable supertrait 

    To resolve dalek-cryptography#94, removes the `Copy` supertrait bound on
`ConditionallySelectable`, replacing it with `Sized` instead.

It turns out the bound is only used in the default implementation of
`ConditionallySelectable::conditional_swap`, and is easy to replace by
slightly changing that default implementation.

Removing this supertrait bound is arguably a breaking change since it
means types which impl `ConditionallySelectable` can no longer be
assumed to be `Copy`, so also bumps the version to `3.0.0-pre`.
    @tarcieri
    tarcieri committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    a3acd6c View commit details
    Browse the repository at this point in the history