Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for X-Wing. #444

Merged
merged 8 commits into from
Nov 3, 2024
Merged

Add support for X-Wing. #444

merged 8 commits into from
Nov 3, 2024

Conversation

dajiaji
Copy link
Owner

@dajiaji dajiaji commented Nov 3, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 100 lines in your changes missing coverage. Please review.

Project coverage is 88.47%. Comparing base (d9957ad) to head (b9b3f7f).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
packages/hybridkem-x-wing/src/hybridkemXWing.ts 69.38% 94 Missing ⚠️
packages/dhkem-x25519/src/x25519.ts 62.50% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #444      +/-   ##
==========================================
- Coverage   89.90%   88.47%   -1.43%     
==========================================
  Files          58       60       +2     
  Lines        4387     4712     +325     
  Branches      415      448      +33     
==========================================
+ Hits         3944     4169     +225     
- Misses        442      542     +100     
  Partials        1        1              
Flag Coverage Δ
unittests 88.47% <69.23%> (-1.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dajiaji dajiaji force-pushed the add-support-for-x-wing branch from b0dc55a to e8a0d44 Compare November 3, 2024 13:45
@dajiaji dajiaji force-pushed the add-support-for-x-wing branch from 1ca1ee1 to 756a0d1 Compare November 3, 2024 14:06
@dajiaji dajiaji merged commit feeffc0 into main Nov 3, 2024
14 checks passed
@dajiaji dajiaji deleted the add-support-for-x-wing branch November 3, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants