fix(Swap): prevent onclick from firing twice by moving from label to …

…inner input
daisyui · Oct 5, 2023 · 6478b1b · 6478b1b
1 parent c3ebfd4
commit 6478b1b
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/Swap/Swap.tsx b/src/Swap/Swap.tsx
@@ -5,13 +5,15 @@ import { twMerge } from 'tailwind-merge'
 import { IComponentBaseProps } from '../types'
 import { wrapWithElementIfInvalid } from '../utils'
 
-export type SwapProps = React.LabelHTMLAttributes<HTMLLabelElement> &
+export type SwapProps = Omit<React.LabelHTMLAttributes<HTMLLabelElement>, 'onClick' | 'onChange'> &
   IComponentBaseProps & {
     onElement: ReactNode | ReactNode[]
     offElement: ReactNode | ReactNode[]
     active?: boolean
     rotate?: boolean
     flip?: boolean
+    onClick?: React.MouseEventHandler<HTMLInputElement>
+    onChange?: React.FormEventHandler<HTMLInputElement>
   }
 
 const Swap = React.forwardRef<HTMLLabelElement, SwapProps>(
@@ -24,6 +26,8 @@ const Swap = React.forwardRef<HTMLLabelElement, SwapProps>(
       flip,
       dataTheme,
       className,
+      onClick,
+      onChange,
       ...props
     },
     ref
@@ -53,7 +57,7 @@ const Swap = React.forwardRef<HTMLLabelElement, SwapProps>(
 
     return (
       <label {...props} data-theme={dataTheme} className={classes} ref={ref}>
-        <input type="checkbox" />
+        <input type="checkbox" onClick={onClick} onChange={onChange} />
         {onEl}
         {offEl}
       </label>