Skip to content

Commit

Permalink
Fix build on Windows: "mvn" executable does not exist
Browse files Browse the repository at this point in the history
It can only be used instead of mvn.cmd when run in a shell.
  • Loading branch information
bertfrees committed Dec 9, 2022
1 parent f12e1bd commit 84a43ab
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@ jobs:
key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
restore-keys: |
${{ runner.os }}-maven-
- name: Build .deb file
- name: Build Windows ZIP distribution
shell: cmd
run: .\\make.exe deb
run: .\\make.exe zip-win
9 changes: 7 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,15 @@ SHELL := make/eval-java
endif
.SHELLFLAGS :=

OS := $(shell println(getOS());)

ifeq ($(OS), WINDOWS)
MVN ?= mvn.cmd
else
MVN ?= mvn
DOCKER := docker
endif

OS := $(shell println(getOS());)
DOCKER := docker

.PHONY : default
ifeq ($(OS), WINDOWS)
Expand Down

0 comments on commit 84a43ab

Please sign in to comment.