Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing noble test due padding #6

Merged
merged 2 commits into from
Sep 10, 2023
Merged

Fix failing noble test due padding #6

merged 2 commits into from
Sep 10, 2023

Conversation

nalinbhardwaj
Copy link
Member

@nalinbhardwaj nalinbhardwaj commented Sep 10, 2023 •
edited
Loading

does seem to fix it

dcposch
dcposch approved these changes Sep 10, 2023
View reviewed changes
Copy link
Member

@dcposch dcposch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice, looks great. I'll update it so we do this in the vector file generation instead

@dcposch dcposch force-pushed the nibnalin/fix-noble-fail branch from 400bc63 to 412ad1e Compare September 10, 2023 01:54
@dcposch dcposch merged commit 412ad1e into master Sep 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcposch dcposch dcposch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nalinbhardwaj @dcposch