WebAuthn.sol: simplify contains to startsWith #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalinbhardwaj
force-pushed
the
nibnalin/webauthn-streamlining
branch
2 times, most recently
from
f410102 to
d115157
Compare
nalinbhardwaj
force-pushed
the
nibnalin/webauthn-streamlining
branch
from
d115157 to
0599b98
Compare
dcposch
approved these changes
May 19, 2024
| challengeB64url, | ||
| '"' | ||
| ); | ||
|
|
||
| if (!contains(challengeProperty, clientDataJSON, challengeLocation)) { | ||
| if (!startsWith(prefix, clientDataJSON)) { |
nalinbhardwaj
added a commit
that referenced
this pull request
May 19, 2024
0xBigBoss
pushed a commit
to 0xBigBoss/p256-verifier
that referenced
this pull request
Jul 11, 2024
0xBigBoss
pushed a commit
to 0xBigBoss/p256-verifier
that referenced
this pull request
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assumes more strictly than before that signatures follow the WebAuthn spec serialization.
PR into
nextbranch -- we can use that as our base until audit.