Skip to content

Commit

Permalink
N-01: add security contact
Browse files Browse the repository at this point in the history
  • Loading branch information
dcposch committed Aug 2, 2024
1 parent 8279636 commit 192a4a7
Show file tree
Hide file tree
Showing 6 changed files with 206 additions and 512 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ env:
jobs:
test:
runs-on: ubuntu-latest
env:
FOUNDRY_GAS_LIMIT: 10000000000
steps:
- uses: actions/checkout@v3
with:
Expand All @@ -23,11 +25,11 @@ jobs:

- run: |
forge --version
forge build --sizes
forge build --via-ir --sizes
id: build
- run: |
forge test -vv
forge test --via-ir -vv
forge coverage --ir-minimum --report lcov
git diff --exit-code
id: test
Expand Down
7 changes: 4 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ Our implementation was inspired by [Renaud Dubois/Ledger's FCL library](https://
Available on any chain. If missing, see `deploy.sh`.

Install with:

- `forge install daimo-eth/p256-verifier`
- add `p256-verifier/=lib/p256-verifier/src/` to remappings.txt

Expand All @@ -33,7 +34,7 @@ uint256 x, y; // public key
bool valid = P256.verifySignature(hash, r, s, x, y);
```

Alternately, calling `P256.verifySignatureAllowMalleability` ignores
Alternately, calling `P256.verifySignatureAllowMalleability` ignores
malleability of signatures, matching the behavior specified by the NIST standard
exactly.

Expand All @@ -51,7 +52,7 @@ Run `foundryup` to ensure you have the latest foundry. Then,
```
git clone --recurse-submodules [email protected]:daimo-eth/p256-verifier
cd p256-verifier
forge test -vv
forge test --via-ir -vv
```

This runs test input and output handling as well as all applicable Wycheproof
Expand Down Expand Up @@ -87,7 +88,7 @@ npm test
# Validate that all vectors also work with EIP-7212
# Test the fallback contract...
cd ..
forge test -vv
forge test --via-ir -vv
# In future, execution spec and clients can test against the same clean vectors
```
Expand Down
Loading

0 comments on commit 192a4a7

Please sign in to comment.