contract: intent addrs #1351
Closed
contract: intent addrs #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
andrewliu08
reviewed
Oct 3, 2024
Comment on lines
12
to
13
| /// @dev Zero address = native asset, eg ETH | ||
| IERC20 addr; |
There was a problem hiding this comment.
should we make this address rather than IERC20 since this could be a native asset?
nalinbhardwaj
force-pushed
the
internal
branch
from
039cef2 to
28b1edb
Compare
|
superseded by #1353 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update CrepeHandoff:
work in progress