api: load ENS names once (#1080)

fixes #1048
daimo-eth · May 28, 2024 · 5094073 · 5094073
1 parent d4c0130
commit 5094073
Showing 1 changed file with 24 additions and 11 deletions.
diff --git a/packages/daimo-api/src/contract/nameRegistry.ts b/packages/daimo-api/src/contract/nameRegistry.ts
@@ -84,6 +84,8 @@ export class NameRegistry extends Indexer {
   private addrToReg = new Map<Address, Registration>();
   private accounts: DAccount[] = [];
 
+  private ensReverseLookups = new Map<Address, Promise<string | undefined>>();
+
   logs: Registration[] = [];
 
   constructor(
@@ -225,25 +227,36 @@ export class NameRegistry extends Indexer {
     if (label) return { addr: address, label };
 
     // Finally, ENS reverse lookup
-    let ensName: string | undefined = undefined;
+    let promise = this.ensReverseLookups.get(address);
+    if (promise == null) {
+      promise = this.getENSReverseLookup(address);
+    }
+    const ensName = await promise;
+
+    // Bare addresses are fine too, ensName can be undefined
+    return { addr: address, ensName };
+  }
+
+  async getENSReverseLookup(address: Address): Promise<string | undefined> {
     try {
       console.log(`[NAME-REG] looking up ENS name for ${address}`);
-      ensName = (await this.vc.getEnsName({ address })) || undefined;
+      const ensName = (await this.vc.getEnsName({ address })) || undefined;
+      if (ensName == null) {
+        return undefined;
+      }
+
       // Verify the forward lookup
-      if (ensName != null) {
-        const addr = await this.vc.getEnsAddress({ name: ensName });
-        if (addr !== address) {
-          console.warn(`[NAME-REG] bad ENS ${address} > ${ensName} > ${addr}`);
-          ensName = undefined;
-        }
+      const addr = await this.vc.getEnsAddress({ name: ensName });
+      if (addr !== address) {
+        console.warn(`[NAME-REG] bad ENS ${address} > ${ensName} > ${addr}`);
+        return undefined;
       }
       console.log(`[NAME-REG] ENS name for ${address}: ${ensName}`);
+      return ensName;
     } catch (e) {
       console.log(`[NAME-REG] ENS lookup failed for ${address}: ${e}`);
+      return undefined;
     }
-
-    // Bare addresses are fine too, ensName can be undefined
-    return { addr: address, ensName };
   }
 
   /** Gets an Ethereum account given "alice", "bob.eth", or "0x..." */