feat: highlighted views and queries #1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capJavert
changed the title
rebelchris
approved these changes
May 30, 2024
sshanzel
approved these changes
May 30, 2024
| import cron from '../../src/cron/updateHighlightedViews'; | ||
|
|
||
| describe('updateHighlightedViews cron', () => { | ||
| it('should be registered', () => { |
There was a problem hiding this comment.
I like this. Registering the worker gets missed sometimes and this would ensure they got listed.
There was a problem hiding this comment.
Yep, all the recent crons/worker have this 👌
nensidosari
approved these changes
May 30, 2024
idoshamun
approved these changes
May 30, 2024
|
@idoshamun // @omBratteng // @nensidosari I've now added all queries/test and cleaned up unused field in MVs |
omBratteng
reviewed
May 30, 2024
omBratteng
approved these changes
May 30, 2024
Co-authored-by: Ole-Martin Bratteng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation from