feat: migrate transactional emails to cio #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
idoshamun
commented
May 27, 2024
| @@ -683,64 +683,6 @@ describe('generateNotification', () => { | |||
| ]); | |||
| }); | |||
|
|
|||
| it('should generate squad_post_viewed notification', () => { | |||
There was a problem hiding this comment.
This notification is no longer used
This comment has been minimized.
This comment has been minimized.
idoshamun
commented
May 27, 2024
| @@ -1049,24 +991,6 @@ describe('storeNotificationBundle', () => { | |||
| expect(actual.attachments.length).toEqual(0); | |||
| }); | |||
|
|
|||
| it('should generate squad_access notification', () => { | |||
There was a problem hiding this comment.
This notification is no longer used
idoshamun
commented
May 27, 2024
| if (!('id' in data.identifiers)) { | ||
| throw new Error('identifiers.id is required'); | ||
| } | ||
| const token = await signJwt({ |
There was a problem hiding this comment.
Required for custom unsubscribe as mentioned here:
https://customer.io/docs/journeys/custom-unsubscribe-links/
Still WIP but most of the work is done. I placed some todos that I need to fix, I'm waiting for a response from their support. It actually required more changes than I expected as some things are not supported: * Sending emails in batches with personalization parameters * Generating batch id for the digest
idoshamun
changed the title
This comment has been minimized.
This comment has been minimized.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
capJavert
reviewed
May 28, 2024
| @@ -127,7 +119,6 @@ export const features = { | |||
| }), | |||
| dailyDigest: new Feature('daily_personalized_digest', { | |||
| ...digestFeatureBaseConfig, | |||
| templateId: 'd-925d2759ddd641f99220b3c7c6836458', | |||
There was a problem hiding this comment.
Digests now have the same template ID by default?
There was a problem hiding this comment.
yes. nimrod asked to merge the templates together
src/routes/index.ts
Outdated
Comment on lines
141
to
142
| fastify.post<{ Querystring: { token: string } }>( | ||
| '/unsubscribe', |
There was a problem hiding this comment.
Maybe move under /notifications, separate file or just add to path.
rebelchris
approved these changes
May 28, 2024
| category: 'Digests', | ||
| asmGroupId: 23809, | ||
| }, | ||
| templateId: '46', |
There was a problem hiding this comment.
Don't we need to update more templateId's?
Or we'll do the main ones seperate later?
There was a problem hiding this comment.
you can see them all here:
https://github.com/dailydotdev/daily-api/pull/1940/files/9c9534a993b36491422f9bbcc37cbb90911eb261#diff-f67cd567f4bd2a88174440296b31d02af4791f49dcb989705e5995f837625978R47
this change was specific to digest
|
🍹 The Update (preview) for dailydotdev/api/prod was successful. Resource Changes Name Type Operation
~ vpc-native-update-tag-recommendations-cron kubernetes:batch/v1:CronJob update
~ vpc-native-generate-search-invites-cron kubernetes:batch/v1:CronJob update
+ vpc-native-api-migration-0761068c kubernetes:batch/v1:Job create
~ vpc-native-daily-digest-cron kubernetes:batch/v1:CronJob update
~ vpc-native-ws-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-check-analytics-report-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-trending-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-source-tag-view-cron kubernetes:batch/v1:CronJob update
~ vpc-native-bg-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-update-discussion-score-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-views-cron kubernetes:batch/v1:CronJob update
~ vpc-native-export-to-tinybird-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-tags-str-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-zombie-images-cron kubernetes:batch/v1:CronJob update
~ vpc-native-personalized-digest-cron kubernetes:batch/v1:CronJob update
~ vpc-native-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-private-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-personalized-digest-deployment kubernetes:apps/v1:Deployment update
- vpc-native-api-migration-f868865a kubernetes:batch/v1:Job delete
+- vpc-native-k8s-secret kubernetes:core/v1:Secret create-replacement
~ vpc-native-clean-zombie-users-cron kubernetes:batch/v1:CronJob update
~ vpc-native-generic-referral-reminder-cron kubernetes:batch/v1:CronJob update
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still WIP but most of the work is done. I placed some todos that I need to fix, I'm waiting for a response from their support.
It actually required more changes than I expected as some things are not supported: