feat: onboarding follow sources #3867
Merged
+355
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebelchris
requested review from
omBratteng,
ilasw,
capJavert,
sshanzel,
nensidosari and
AmarTrebinjac
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
rebelchris
commented
Nov 22, 2024
| @@ -53,8 +59,7 @@ export const OnboardingHeader = ({ | |||
| position={LogoPosition.Relative} | |||
| linkDisabled | |||
| /> | |||
| {(activeScreen === OnboardingStep.EditTag || | |||
| activeScreen === OnboardingStep.ContentTypes) && ( | |||
| {showButtonOnScreens.includes(activeScreen) && ( | |||
There was a problem hiding this comment.
More readable in my opinion
rebelchris
commented
Nov 22, 2024
rebelchris
commented
Nov 22, 2024
| @@ -148,6 +148,7 @@ export default { | |||
| 6: '0.375rem', | |||
| 8: '0.5rem', | |||
| 10: '0.625rem', | |||
| 11: '0.6875rem', | |||
There was a problem hiding this comment.
Needed for inner border, else @omBratteng would get angry
review.mp4It sometimes falls back to initial data while it's pending. |
omBratteng
requested changes
Nov 22, 2024
|
Tested in preview, and it works fine |
rebelchris
commented
Nov 22, 2024
omBratteng
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add option to follow sources during onboarding.
Initial source recommendations are based on tags you selected:
You can also search:
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
AS-678 #done
Preview domain
https://as-678-follow-sources-onboarding.preview.app.daily.dev