fix: date comparison without timezone in consideration #3832
Conversation
sshanzel
requested review from
rebelchris,
omBratteng,
ilasw,
capJavert,
nensidosari and
AmarTrebinjac
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
| const isLaptop = useViewSize(ViewSize.Laptop); | ||
| const isMobile = useViewSize(ViewSize.MobileL); | ||
| const [shouldShowStreaks, setShouldShowStreaks] = useState(false); | ||
| const hasReadToday = | ||
| new Date(streak?.lastViewAt).getDate() === new Date().getDate(); | ||
| const hasReadToday = getHasReadToday(streak?.lastViewAt, user?.timezone); |
There was a problem hiding this comment.
But shouldn't API just return it in the correct format already?
There was a problem hiding this comment.
Currently, what is returned is the stored value, which is UTC.
There was a problem hiding this comment.
We can maybe add a prop where the returned value involves the right tz.
There was a problem hiding this comment.
Introduced an API change for the timezome-adjusted value: dailydotdev/daily-api#2471
There was a problem hiding this comment.
So then we don't need this one?
There was a problem hiding this comment.
For backwards compatibility, I have kept the original column, and introduced a new one with timezone considered. So we'd still need this PR 🙏
Changes
lastViewAtis in UTC when fetched from the API, which does not match the local time. With the update, we will utilize the user's set timezone. We can also use the current local timezone but it won't match other stats since behind the scenes all we use is the set timezone from the profile.Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Preview domain
https://mi-620.preview.app.daily.dev