Convert variation in carriers and turrets to new format #2165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i just realised, that the new settings cannot get recognised, as I would also need to change getScenarioVariation() to getScenarioSetting("Difficulty"). And then I realised that the old setting probably never did anything in the first place, as while there is a setVariations() function that would take care of it, it never gets called. |
Successor of the "none" variation, so no additional checks in setVariations() are needed
Piglit
pushed a commit
to Piglit/EmptyEpsilon
that referenced
this pull request
Oct 8, 2024
* Convert variation in carriers and turrets to new format so it is translatable * recognise the difficulty settings * add default "normal" option Successor of the "none" variation, so no additional checks in setVariations() are needed
Tsht
pushed a commit
to Tsht/EmptyEpsilon
that referenced
this pull request
Oct 12, 2024
* Convert variation in carriers and turrets to new format so it is translatable * recognise the difficulty settings * add default "normal" option Successor of the "none" variation, so no additional checks in setVariations() are needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted the old scenario variation to a difficulty setting in the new format, so the update locale script can generate translation entries for it.