Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECS: re-implement mesh rendering in database entries #2140

Merged

Commits on Aug 16, 2024

  1. Use MeshRenderSystem::render3D as a starting point

    - Total duplication of the code there.  Will extract soon, if appropriate
    kzsh committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    3a1c9c3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d61d6f9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    799236b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    30bb110 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    173784e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    656cb7a View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2024

  1. Remove unused commented code

    The same projection is happening already a few lines above
    kzsh committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    49d5c7e View commit details
    Browse the repository at this point in the history
  2. Group remaining behavior into functions

    These functions are somewhat arbitrary, but might be a
    good starting point for a final form.  Providing these
    functions from rendering.h is still only temporary.
    kzsh committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    d7668e5 View commit details
    Browse the repository at this point in the history
  3. Use overload instead of attempted 'optional'

    My reflexes were for optional arguments, but an overload seems more
    correct.
    kzsh committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    ec1ba80 View commit details
    Browse the repository at this point in the history
  4. Adjust where we scale and translate

    This seems to give a better result for a large variety of different original
    model scales.  E.g. average vertex from 'center' of Atlantis is 30-40 whereas
    an MP52 is 1ish.
    kzsh committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    6751593 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    57abd52 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Configuration menu
    Copy the full SHA
    77667c3 View commit details
    Browse the repository at this point in the history
  2. Pass entity instead of mesh to render view

    This isn't necessary to render the mesh, but it will be useful
    when trying to look up beam emitter and engine emitters to
    render in debug mode
    kzsh committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    2d0405c View commit details
    Browse the repository at this point in the history
  3. Don't flip the matrix twice

    kzsh committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    94385c0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a4abc9f View commit details
    Browse the repository at this point in the history
  5. Ensure no change to GL settings from previous

    When copying behavior from viewport3D we adopted some behavior
    from it that doesn't seem necessary for this view
    kzsh committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    756d80b View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Rename 'mesh' to 'mrc'

    kzsh committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    e8de738 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c385337 View commit details
    Browse the repository at this point in the history
  3. Clarify comment

    kzsh committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    8c83569 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bce21a5 View commit details
    Browse the repository at this point in the history
  5. Fix spacing

    kzsh committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    4743c50 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Simplify logic with glm:vec3

    kzsh committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    db134a8 View commit details
    Browse the repository at this point in the history