-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme selection in option menu #2088
Conversation
@Tsht By theme, do you mean just changing the font in the future ? |
And, the translation tag was not added to be able to translate the word "Default". Can you add it? |
@muerteFR Hello. Theme is a mechanism to modify some elements for the UI, look for instance in : https://github.com/daid/EmptyEpsilon/blob/master/resources/gui/default.theme.txt I don't know if it makes sense to translate "default" as it's just the file name... If you create "other.theme.txt", then you will have the choice to also select "other". |
Maybe someting like "default (Default theme)" translated : "default (thème par défaut)" ? |
Yes it would be good like that. |
problem is, this name comes directly from the filename, so that isn't translation aware. Not sure how to fix that yet. |
ok |
But, if there is only 1 theme, I made this selector hidden, so per default you won't see it right now. Gives us some time to test this and think about how to translate it before it's default exposed. |
Actually, not quite. The language indicator is not translated either. Basically the same thing, in that it is just part of the filename(s). I think that works because many people are used to those indicator, so they serve as some kind of proper name. Also it makes it easier to change the language back, if you don't know what a language is called in another one. |
* Theme selection * Remove dependency from canvas to preference manager, tradoff by static member * Forgotten occurrence in main * Change font when changing theme
Every theme found in gui, *.theme.txt, are loaded when entering option screen. This is primarily to test validation.