[GuiScrollbar] Scrollbar limits fixed #2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
csibbitt
commented
Oct 15, 2023
•
csibbitt
commented
- Problems with range calculations prevented access to full range in large lists
- These adjustments allow drag-scrolling to the end without any slop
- Tested on:
- Comms smaller than the window
- Comms larger than the window
- A log smaller than the window
- A log with 10,000 entries
- Fixes [GuiScrollbar] Draggable bar size has no lower bound #1940
- Fixes [GuiScrollbar] Scrollbar bottom range can be positioned below bottom arrow, where user can't scroll #1941
* Problems with range calculations prevented access to full range in large lists * These adjustments allow drag-scrolling to the end without any slop * Tested on: ** Comms smaller than the window ** Comms larger than the window ** A log smaller than the window ** A log with 10,000 entries
Tsht
pushed a commit
to Tsht/EmptyEpsilon
that referenced
this pull request
Nov 22, 2023
* [GuiScrollbar] Move copy/paste updates to onDraw, persist values * [GuiScrollbar] Prevent draggable bar from dropping to below bottom arrow button * [GuiScrollbar] Enable full range on large lists * Problems with range calculations prevented access to full range in large lists * These adjustments allow drag-scrolling to the end without any slop * Tested on: ** Comms smaller than the window ** Comms larger than the window ** A log smaller than the window ** A log with 10,000 entries --------- Co-authored-by: oznogon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.