[ShipsLogControl] Fix update failure with duplicate text #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a sequence # to log messages * Store seq in GuiAdvancedScrollText along with rest of log data * Compare seq instead of text when sync'ing ScrollText to log * Fixes Issue daid#1947
|
Looks good enough for now. On the ECS branch this will be handled a bit differently. But, we're not there yet :) |
Tsht
pushed a commit
to Tsht/EmptyEpsilon
that referenced
this pull request
Nov 22, 2023
* Add a sequence # to log messages * Store seq in GuiAdvancedScrollText along with rest of log data * Compare seq instead of text when sync'ing ScrollText to log * Fixes Issue daid#1947
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm hoping this sequence # will also come in useful when I look at optimizing the network sync of the ship's log.