Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static waypoint labels #1363

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Static waypoint labels #1363

wants to merge 5 commits into from

Conversation

hemmond
Copy link
Contributor

@hemmond hemmond commented Mar 19, 2021

Waypoint labels are now static. After waypoint removal, the rest of the waypoints retains their number. When adding waypoint, first free number is used as label of the waypoint.

I recommend squashing commits into one during merge.

@daid
Copy link
Owner

daid commented Apr 7, 2021

This breaks how the LUA API is used:
https://github.com/daid/EmptyEpsilon/blob/master/scripts/comms_ship.lua#L52

@hemmond
Copy link
Contributor Author

hemmond commented Apr 7, 2021

Could PlayerSpaceship:getWaypointLabel(int index) then be introduced to LUA, which will return proper label? Stock LUA scripts will then still work as expected, custom scripts will have "different" numbers but will not crash. Could that be accepted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hemmond @daid @gcask