chore: bump swc
#901
chore: bump swc
#901
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
| @@ -88,7 +88,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@netlify/functions": "^2.8.1", | |||
| "@swc/cli": "^0.4.0", | |||
| "@swc/cli": "0.4.1-nightly.20240914", | |||
There was a problem hiding this comment.
Does it conflict if we keep using 0.4.0?
| const createIdentifier = (value: string): swc.Identifier => ({ | ||
| type: 'Identifier', | ||
| value, | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-expect-error | ||
| ctxt: 0, |
There was a problem hiding this comment.
Hm, we need it in this position... So, if swc fixes the TS type, the @ts-expect-error will be gone?
| optional: false, | ||
| span: { start: 0, end: 0, ctxt: 0 }, | ||
| span: createEmptySpan(), |
There was a problem hiding this comment.
Just to confirm, does it work if this is span: { start: 0, end: 0 }? Or, does TS complain?
There was a problem hiding this comment.
span: { start: 0, end: 0 }. swc type is broken
There was a problem hiding this comment.
How is it likely that swc will fix this type issue sometime soon-ish?
There was a problem hiding this comment.
/cc @kdy1 @magic-akari
|
Thanks for opening the upstream issue. It seems like nobody else is using swc like us. 😄 Actually, there is another issue already filed: swc-project/swc#9564 |
|
well, they recommend write rust |
|
not sure If I should put rust version of parser to a higher prority. |
|
I don't think it's a priority, unless it's the bottleneck of the performance. |
|
our final goal would be rolldown, maybe? |
Fixes: #845