Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gitignore to Simplify Project Creation from Template #89

Closed
wants to merge 1 commit into from

Conversation

JiantingFeng
Copy link

I noticed that in creating a new project from the template, some files (like local environment files, build files, etc.) that should not be pushed to the repo are being included. This causes additional steps for the users to remove or update these files to suit their specific project.

I have added a .gitignore file to the template to streamline this process and make it more user-friendly. This file includes standard patterns for ignoring files that are typically unnecessary in the repo.

This will make the project creation process more straightforward and help maintain the cleanliness and relevance of the repository files.

You can see the changes I have made in this pull request.

I appreciate your time and consideration. Kindly review these changes and let me know if there are any suggestions or issues.

Add .gitignore to example project
@vercel
Copy link

vercel bot commented Jun 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2023 3:37am

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d0241b5:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
React Configuration
React Typescript Configuration

@dai-shi
Copy link
Owner

dai-shi commented Jun 28, 2023

Thanks for the suggestion. We'll be re-creating create-waku #81 (comment), so let's do it there. Please give some more time.

@dai-shi
Copy link
Owner

dai-shi commented Jan 17, 2024

#24 (comment)
@ojj1123 It's once rejected, but we may consider it again for v0.20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants