Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dagster-looker] Pin sqlglot>=25.19.0 #26056

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[dagster-looker] Pin sqlglot>=25.19.0 #26056

wants to merge 1 commit into from

Conversation

maximearmstrong
Copy link
Contributor

@maximearmstrong maximearmstrong commented Nov 20, 2024 •
edited
Loading

Summary & Motivation

Code fails with sqlglot<25.19.0 because we use Dialect.SET_OP_DISTINCT_BY_DEFAULT that was introduced in 25.19.0.

Also rebuild pyright pins.

How I Tested These Changes

Local tests + BK

@maximearmstrong Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@maximearmstrong maximearmstrong marked this pull request as ready for review November 20, 2024 20:45
@maximearmstrong maximearmstrong self-assigned this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alangenfeld alangenfeld alangenfeld approved these changes

@smackesey smackesey Awaiting requested review from smackesey

@danielgafni danielgafni Awaiting requested review from danielgafni

Assignees

@maximearmstrong maximearmstrong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maximearmstrong @alangenfeld