[core, pipes] escaping slashes in asset keys #25742
Open
+239
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @danielgafni and the rest of your teammates on |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| called = {} | ||
|
|
||
| def _impl(context: PipesContext): | ||
| breakpoint() |
There was a problem hiding this comment.
Please remove the breakpoint() statement before merging to avoid unintended debugging interruptions in production code.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
danielgafni
changed the title
danielgafni
force-pushed
the
11-04-_pipes_asset_keys_escaping
branch
from
186790c
to
9c275fb
Compare
danielgafni
force-pushed
the
11-04-_pipes_asset_keys_escaping
branch
from
9c275fb
to
e2f824b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Added support for asset keys containing forward slashes by implementing escape characters. This allows asset keys to include forward slashes within their components while maintaining the ability to use forward slashes as separators between components. For example,
"foo/bar"can now be represented as"foo\/bar".Slashes are escaped before sending the asset key to Pipes and are de-escaped when handling Pipes messages.
How I Tested These Changes
Changelog
Bugfix: [pipes] Added support for escaped forward slashes in asset keys, allowing asset key components to contain forward slashes when properly escaped with backslashes.