-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dagster-azure] add support for US Government Cloud tenant #25738
Open
lilygrierjil
wants to merge
24
commits into
dagster-io:master
Choose a base branch
from
lilygrierjil:issue-7790
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+188
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This PR addresses issue #7790 by removing the hard-coding to the Azure commercial cloud tenant and adding a
cloud_type
parameter that can accept eitherpublic
orgovernment
, which can be specified in the ADLS2 configurations. This value defaults topublic
, so existing code calling these functions can run without breaking. The PR adds aprimary_endpoint
parameter toADLS2FileHandle
so the appropriate subdomain gets propagated from theADLS2Resource
.How I Tested These Changes
test_adls2_pickle_io_manager_uri
to ensure the correct URI is generatedtest_adls_file_handle_adls2_path
to ensure the file path changes based on thecloud_type
parameter (and that the path reflects the public cloud tenant when no cloud_type is supplied)test_adls_file_manager_resource_cloud_type
to ensure assets are materialized without error when specifying the government cloud typepytest dagster_azure_tests/
to ensure all tests (old and new) run successfullyChangelog