[core] investigate slashes in asset keys #25728
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @danielgafni and the rest of your teammates on |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+52
to
+54
| assert AssetKey(["foo/bar", "baz", "quix"]) in keys1 | ||
| assert AssetKey(["foo/bar", "baz", "quix"]) in keys1 |
There was a problem hiding this comment.
Line 53 appears to be a duplicate of line 52, both asserting AssetKey(["foo/bar", "baz", "quix"]) in keys1. One of these assertions can be removed.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
danielgafni
force-pushed
the
11-04-_core_investigate_slashes_in_asset_keys
branch
from
17b7569
to
208a03a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
How I Tested These Changes
Changelog