[FOU-471] Implement AssetSelectionVisitor #25704
Draft
+284
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
briantu
changed the title
|
This looks solid! More comprehensive tests please |
briantu
force-pushed
the
briantu/implement-visitor
branch
from
8332174
to
c986cb2
Compare
briantu
force-pushed
the
briantu/new-asset-selection-syntax
branch
from
48c1447
to
877b79d
Compare
briantu
force-pushed
the
briantu/implement-visitor
branch
2 times, most recently
from
c74899f
to
6210497
Compare
briantu
force-pushed
the
briantu/new-asset-selection-syntax
branch
from
877b79d
to
9d4443c
Compare
briantu
force-pushed
the
briantu/implement-visitor
branch
from
d4879e8
to
1020612
Compare
briantu
changed the base branch from
briantu/new-asset-selection-syntax
to
briantu/set-up-antlr-asset-selection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
We want to actual implement the visitor functions that ANTLR provides us. These functions will use the existing methods from the
AssetSelectionclass to construct theAssetSelection.How I Tested These Changes
Changelog