[dagster-tableau] Rename Tableau asset builder fn #25667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @maximearmstrong and the rest of your teammates on |
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-9vof1e68z-elementl.vercel.app Direct link to changed pages: |
|
Deploy preview for dagster-docs-beta ready! Preview available at https://dagster-docs-beta-mzlctekpw-elementl.vercel.app Direct link to changed pages: |
This was referenced Oct 31, 2024
benpankow
approved these changes
Oct 31, 2024
OwenKephart
pushed a commit
that referenced
this pull request
Oct 31, 2024
## Summary & Motivation Updates fn name to `build_tableau_materializable_asset_definitions` to be consistent with Dagster external vs materializable assets. Subsequent PR will add an asset spec parser function that users could use to split their asset specs in external and materializable asset specs - the goal is to make the Tableau boilerplate more elegant and easy to implement. ## How I Tested These Changes Updated tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Updates fn name to
build_tableau_materializable_asset_definitionsto be consistent with Dagster external vs materializable assets.Subsequent PR will add an asset spec parser function that users could use to split their asset specs in external and materializable asset specs - the goal is to make the Tableau boilerplate more elegant and easy to implement.
How I Tested These Changes
Updated tests