Skip to content

Commit

Permalink
[ui] block backfills page on main content (#22561)
Browse files Browse the repository at this point in the history
We were blocking on the instance health query but not the main content
query, so add that.

## How I Tested These Changes
  • Loading branch information
alangenfeld authored Jun 14, 2024
1 parent d1c01bf commit 8633fa7
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ export const InstanceBackfills = () => {
InstanceHealthForBackfillsQuery,
InstanceHealthForBackfillsQueryVariables
>(INSTANCE_HEALTH_FOR_BACKFILLS_QUERY);
useBlockTraceOnQueryResult(queryData, 'InstanceHealthForBackfillsQuery');

const [statusState, setStatusState] = useQueryPersistedState<Set<BulkActionStatus>>({
encode: (vals) => ({status: vals.size ? Array.from(vals).join(',') : undefined}),
Expand Down Expand Up @@ -105,6 +104,7 @@ export const InstanceBackfills = () => {
? result.partitionBackfillsOrError.results
: [],
});
useBlockTraceOnQueryResult(queryResult, 'InstanceBackfillsQuery'); // this is the main page content

const refreshState = useQueryRefreshAtInterval(queryResult, FIFTEEN_SECONDS);
const {loading, data} = queryResult;
Expand Down

1 comment on commit 8633fa7

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-29p7ov082-elementl.vercel.app

Built with commit 8633fa7.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.