Fix binary copying to temporary folder on custom path #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, on Linux, the executable ends up not being copied due to not having one of the expected extensions. This leads to unexpected behavior when specifying a path to a custom installation, where the specified binary ends up not being copied. This becomes a problem on OSes and distributions, such as NixOS, where the extension's installer doesn't work properly. This change makes it so that the specified binary is copied, no matter its file name.
keyboardDrummer
approved these changes
Oct 9, 2024
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you set a custom path for the CLI through
dafny.cliPath, and setdafny.versiontocustom, in theory, the extension should copy all relevant DLL and executable files in thedafny.cliPathto a tmp dir, which is then used to launch the language server.This is implemented by iterating over all files in the directory of the configured path, and copying only the ones which match a given filter: names ending with
.dll,.exe, etc.On Linux, executables usually won't have those file extensions, and thus, the file the user configured path points to might end up not being copied.
This leads to language server failing because it can't find the file specified in
dafny.cliPath.This PR simply changes the filter so that the file pointed to always passes the filter, so that it always ends up getting copied.