Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize/chore(tuic): allow udp_relay_mode quic #213

Closed
wants to merge 18 commits into from
Closed

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented Jul 13, 2023

Background

This PR allows udp_relay_mode quic, because native mode may have packet loss without any retrying.

NOTICE: But notice that quic mode should be fixed in the future due to misbehavior. See more: https://github.com/EAimTY/tuic/issues/221

Checklist

Full changelogs

  • optimize udp_relay_mode quic.

@dae-prow
Copy link
Contributor

dae-prow bot commented Jul 16, 2023

❌ Your branch is currently out-of-sync to main. No worry, I will fix it for you.

@mzz2017 mzz2017 marked this pull request as ready for review July 16, 2023 14:00
@mzz2017 mzz2017 marked this pull request as draft July 16, 2023 14:13
@mzz2017 mzz2017 marked this pull request as ready for review July 16, 2023 15:29
@mzz2017 mzz2017 changed the title optimize: tuic chore(tuic): allow udp_relay_mode quic Jul 16, 2023
@mzz2017 mzz2017 added the chore label Jul 16, 2023
@mzz2017 mzz2017 changed the title chore(tuic): allow udp_relay_mode quic optimize/chore(tuic): allow udp_relay_mode quic Jul 16, 2023
@mzz2017
Copy link
Contributor Author

mzz2017 commented Jul 17, 2023

TODO: block udp 443 in quic mode temporarily.

Copy link
Contributor

@piyoki piyoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@piyoki
Copy link
Contributor

piyoki commented Aug 2, 2023

TODO: block udp 443 in quic mode temporarily.

Why do we need to block h3 for tuic?

@mzz2017 mzz2017 marked this pull request as draft August 2, 2023 18:11
@mzz2017 mzz2017 closed this Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants